fix(dbt-doc): Allow copying asset when dbt docs command is run outside th… #11219
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @cedric-orange |
|
Before correction, when running After this fix: there is now a directory on target output containing assets. |
There was a problem hiding this comment.
thanks for the PR @cedric-orange! You're right that it's a small change.
Two requests:
- remove the
.devcontainer/devcontainer.jsonfile you've added - if possible add a unit test to ensure we don't break this behavior in future releases. Fix using project-dir with list command and path selector #8388 contains a test that Doug thinks would get you most of the way but needs some tweaking
Looking at the linked issue, there was a unit
|
Thanks for the review, I added a new test according to this topic. I also remove devcontainer.json file. |
Resolves #9308
Problem
The directory assets is not being copied to target/assets when running dbt docs generate if you are not in root dbt project.
Solution
Add dbt_project_dir to asset path
Note: I added a devcontainer.json file to have quickly a full-featured development environment
Checklist